Skip to content
Snippets Groups Projects
  1. Apr 12, 2019
  2. Feb 23, 2019
  3. Feb 15, 2019
  4. Feb 04, 2019
  5. Jan 10, 2019
    • Mark OLESEN's avatar
      ENH: make use of FOAM_API for environment as well (issue #1158) · 63d8e7e5
      Mark OLESEN authored
      - was WM_PROJECT_API in the environment and FOAM_API in dictionaries.
      
        Make these both consistently FOAM_API.
        This is a non-breaking change, since the value of WM_PROJECT_API
        (added in 1812) and/or FOAM_API is purely informative.
        For the current correct values, always use
      
          * foamEtcFile -show-api
          * wmakeBuildInfo -show-api
      63d8e7e5
  6. Feb 06, 2019
  7. Jan 26, 2019
  8. Jan 10, 2019
    • Mark OLESEN's avatar
      ENH: make use of FOAM_API for environment as well (issue #1158) · bef508de
      Mark OLESEN authored
      - was WM_PROJECT_API in the environment and FOAM_API in dictionaries.
      
        Make these both consistently FOAM_API.
        This is a non-breaking change, since the value of WM_PROJECT_API
        (added in 1812) and/or FOAM_API is purely informative.
        For the current correct values, always use
      
          * foamEtcFile -show-api
          * wmakeBuildInfo -show-api
      bef508de
  9. Dec 21, 2018
  10. Dec 10, 2018
  11. Dec 13, 2018
  12. Dec 12, 2018
  13. Dec 10, 2018
  14. Dec 05, 2018
  15. Dec 04, 2018
  16. Dec 03, 2018
    • Mark OLESEN's avatar
      CONFIG: adjustments to environment · b8c257d6
      Mark OLESEN authored
      - provide default WM_DIR if not already set, to improve robustness if a
        reduced environment is used
      
      - add etc/ to WM_PROJECT_SITE search. This makes the site directory
        structure consistent with the OpenFOAM structure.
        Eg,
      
            WM_PROJECT_SITE/etc/..
            WM_PROJECT_SITE/bin/..
            WM_PROJECT_SITE/platforms/..
      
      - Don't set/export WM_OSTYPE.  The default is POSIX and is properly
        defaulted throughout, including in CMakeLists-OpenFOAM.txt (also for
        Catalyst)
      b8c257d6
  17. Dec 02, 2018
    • Mark OLESEN's avatar
      ENH: update handling of versioning and make control (issue #1010) · 6c68c34e
      Mark OLESEN authored
      - Use the OPENFOAM define (eg, 1806, 1812), which normally corresponds
        to a major release, to define an API level. This remains consistent
        within a release cycle and means that it is possible to manage
        several sub-versions and continue to have a consistent lookup.
      
        The current API value is updated automatically during the build
        and cached as meta data for later use, even when the wmake/ directory
        is missing or OpenFOAM has not yet be initialized.
      
        The version information reported on program start or with -help
        usage adjusted to reflect this. The build tag from git now also
        carries the date as being more meaningful to trace than a hash
        value.
      
      - Update etc/bashrc and etc/cshrc to obtain the project directory
        directly instead of via its prefix directory. The value obtained
        corresponds to an absolute path, from which the prefix directory
        can be obtained.
      
        The combination of these changes removes the reliance on any
        particular directory naming convention.
        For example,
      
           With an 1812 version (API level):
      
           WM_PROJECT_VERSION=myVersion
      
           installed as /some/path/somewhere/openfoam-mySandbox
      
        This makes the -prefix, -foamInstall, -projectVersion, -version
        values of foamEtcFiles, and similar entries for foamConfigurePaths
        superfluous.
      
        WM_PROJECT_INST_DIR is no longer required or used
      
      ENH: improve handling and discovery of ThirdParty
      
      - improve the flexibility and reusability of ThirdParty packs to cover
        various standard use cases:
      
          1. Unpacking initial release tar files with two parallel directories
             - OpenFOAM-v1812/
             - ThirdParty-v1812/
      
          2. With an adjusted OpenFOAM directory name, for whatever reason
             - OpenFOAM-v1812-myCustom/
             - openfoam-1812-other-info/
      
          3. Operating with/without ThirdParty directory
      
        To handle these use cases, the following discovery is used.
      
        Note PROJECT = the OpenFOAM directory `$WM_PROJECT_DIR`
             PREFIX = the parent directory
             VERSION = `$WM_PROJECT_VERSION`
             API = `$WM_PROJECT_API`, as per `foamEtcFiles -show-api`
      
         0. PROJECT/ThirdParty
            - for single-directory installations
      
         1. PREFIX/ThirdParty-VERSION
            - this corresponds to the traditional approach
      
         2. PREFIX/ThirdParty-vAPI
            - allows for an updated value of VERSION (eg, v1812-myCustom)
              without requiring a renamed ThirdParty. The API value
              would still be '1812' and the original ThirdParty-v1812/
              would be found.
      
         3. PREFIX/ThirdParty-API
            - this is the same as the previous example, but using an unadorned
              API value. This also makes sense if the chosen version name also
              uses the unadorned API value in its naming
              (eg, 1812-patch190131, 1812.19W03)
      
         4. PREFIX/ThirdParty-common
            - permits maximum reuse for various versions, but only for
              experienced user who are aware of potential version
              incompatibilities
      
         Directory existence is checked as is the presence of an Allwmake file
         or a platforms/ directory. This reduces the potential of false positive
         matches and limits the selection to directories that are either
         with sources (has the Allwmake file), or pre-compiled binaries (has
         the platforms/ directory).
      
         If none of the explored directories are found to be suitable,
         it reverts to using a PROJECT/ThirdParty dummy location since
         this is within the project source tree and can be trusted to
         have no negative side-effects.
      
      ENH: add csh support to foamConfigurePaths
      
      - this removes the previously experienced inconsistence in config file
        contents.
      
      REMOVED: foamExec
      
      - was previously used when switching versions and before the
        bashrc/cshrc discovery logic was added. It is now obsolete.
      6c68c34e
  18. Nov 30, 2018
    • Mark OLESEN's avatar
      ENH: add isTrue function to RunFunctions · c5beee63
      Mark OLESEN authored
      - check if the first argument corresponds to an OpenFOAM value for
        'true' (as per Switch).
        True == 't', 'y', 'true', 'yes', 'on'. Everything else is not true.
      
      - when the first argument is '-dict', it initializes the value
        with a query via foamDictionary.
        Eg,
             isTrue -dict mydict -entry parallel
      
         ==> value=$(foamDictionary mydict -entry parallel -value)
             isTrue $value
      
         a missing entry is silently treated as false.
      
      ENH: add getNumberOfPatchFaces function in RunFunctions
      
      - simple extraction of nFaces from boundary file for given patch/region
      c5beee63
  19. Nov 29, 2018
    • Mark OLESEN's avatar
      ENH: relocate WM_PROJECT_SITE default (issue #1050) · 9e094f1f
      Mark OLESEN authored
      - was PREFIX/site, now PROJECT/site
      
        This avoids several issues when installing OpenFOAM in clusters
        without an intermediate OpenFOAM-specific installation prefix.
      
        The 'site' directory may have a reserved meaning in these situations
        and it is undesirable to 'leak' upwards into the parent directory to
        look for configuration files.
      
        Placing the default within the project directory avoids this.
        Alternative locations can be given via the WM_PROJECT_SITE variable.
      9e094f1f
    • Mark OLESEN's avatar
      ENH: improve setup for paraview · 628b2445
      Mark OLESEN authored
      - removed reliance on ParaView_INCLUDE_DIR variable for conveying the
        major.minor version information when compiling. This can be somewhat
        fragile and also adds variable that is an unnecessary when running
        (only used when compiling).
      
        Instead use `have_pvplugin_support` function in paraviewFunctions
        wmake script to determine the maj.min from the PV_PLUGIN_PATH
        since we have already defined the output path there with paraview
        maj.min numbering.
      
        Can now build with paraview from the operating system,
        provided that it has develop headers available.
      
            ParaView_VERSION=system
      
        In the etc/config.sh/paraview setup, the maj.min is taken from
        the corresponding `paraview --version` output and used when
        defining the PV_PLUGIN_PATH.
      
        During the build, the include path taken from `paraview-config`
        for a system installation, from the guess installation root
        of the paraview binary, or ParaView_DIR otherwise.
      
      NB: using a system ParaView for building runTimePostProcessing is unsupported.
      
      - these types of builds appear to have various library resolution issues
        (eg, libexpat not being loaded). Additionally, the build logic does
        not yet cover this type of use case.
      628b2445
  20. Nov 28, 2018
  21. Nov 25, 2018
  22. Nov 23, 2018
  23. Nov 22, 2018
  24. Nov 21, 2018
  25. Nov 19, 2018
  26. Nov 15, 2018
  27. Oct 15, 2018
  28. Oct 12, 2018