Skip to content
Snippets Groups Projects
  1. Dec 13, 2018
    • Mark OLESEN's avatar
      BUG: stringOps etc expansion fails for directories (issue #1121) · 2db0db30
      Mark OLESEN authored
      - now use findEtcEntry() instead to handle file or directory.
      
        Added findEtcEntries(), which provides provides a common code basis
        for findEtcDirs(), findEtcFiles() ...
      2db0db30
    • Mark OLESEN's avatar
    • Mark OLESEN's avatar
      ENH: consolidate handling of mandatory/optional command arguments · 5d9e278e
      Mark OLESEN authored
      - for some special cases we wish to mark command-line arguments as
        being optional, in order to do our own treatment. For example,
        when an arbitrary number of arguments should be allowed.
      
        Now tag this situation with argList::noMandatoryArgs().
        The argList::argsMandatory() query can then be used in any further
        logic, including the standard default argument checking.
      
      - with the new default check, can consolidate the special-purpose
      
            "setRootCaseNonMandatoryArgs.H"
      
        into the regular
      
            "setRootCase.H"
      
      - revert to a simple "setRootCase.H" and move all the listing related
        bits to a "setRootCaseLists.H" file. This leaves the information
        available for solvers, or whoever else wishes, without being
        introduced everywhere.
      
      - add include guards and scoping to the listing files and rename to
        something less generic.
      
           listOptions.H -> setRootCaseListOptions.H
           listOutput.H  -> setRootCaseListOutput.H
      5d9e278e
  2. Dec 12, 2018
    • Mark OLESEN's avatar
      ENH: support search modes for etcFiles() · 172c36c2
      Mark OLESEN authored
      - similar to the foamEtcFile script -mode=... option, the specific
        search location (user/group/other) can now also specified for
        string expansions and as a numerical value for etcFile()
      
        For example, if searching for group or other (project) controlDict,
        but not wishing to see the user controlDict:
      
          1.  foamEtcFile -mode=go controlDict
      
          2.  fileName dictFile("<etc:go>/controlDict");
              dictFile.expand();
      
          3.  etcFile(controlDict, false, 0077);
      
        The default behaviour for searching all contexts is unchanged.
      
          1.  foamEtcFile controlDict
      
          2.  fileName dictFile("<etc>/controlDict");
              dictFile.expand();
      
          3.  etcFile(controlDict);
      172c36c2
    • Mark OLESEN's avatar
      STYLE: argList::opt method instead of the longer argList::lookupOrDefault · 29a5793b
      Mark OLESEN authored
      - also replaced a few instances of readIfPresent with opt<> for
        constant values.
      29a5793b
    • Mark OLESEN's avatar
      f3819021
  3. Dec 11, 2018
  4. Dec 10, 2018
  5. Dec 08, 2018
    • Mark OLESEN's avatar
      ENH: use foamVersion::api internally in etcFiles searching (#1010) · 5e4d7386
      Mark OLESEN authored
      - prefer this to using the OPENFOAM define since this improves the
        internal consistency with the build information.
      
        The API information could change between builds without the
        etcFiles.C being recompiled whereas the value of
        Foam::foamVersion::api is force updated during the build (triggers
        recompilation of globals.Cver)
      5e4d7386
  6. Dec 06, 2018
  7. Dec 05, 2018
  8. Dec 04, 2018
  9. Dec 03, 2018
    • Mark OLESEN's avatar
      CONFIG: adjustments to environment · b8c257d6
      Mark OLESEN authored
      - provide default WM_DIR if not already set, to improve robustness if a
        reduced environment is used
      
      - add etc/ to WM_PROJECT_SITE search. This makes the site directory
        structure consistent with the OpenFOAM structure.
        Eg,
      
            WM_PROJECT_SITE/etc/..
            WM_PROJECT_SITE/bin/..
            WM_PROJECT_SITE/platforms/..
      
      - Don't set/export WM_OSTYPE.  The default is POSIX and is properly
        defaulted throughout, including in CMakeLists-OpenFOAM.txt (also for
        Catalyst)
      b8c257d6
  10. Nov 29, 2018
    • Mark OLESEN's avatar
      COMP: adjust headers for more detailed build info in the future (issue #1010) · 4b7e11fc
      Mark OLESEN authored
      - this splits a larger changeset for a gradual implementation
      4b7e11fc
    • Mark OLESEN's avatar
      ENH: improve setup for paraview · 628b2445
      Mark OLESEN authored
      - removed reliance on ParaView_INCLUDE_DIR variable for conveying the
        major.minor version information when compiling. This can be somewhat
        fragile and also adds variable that is an unnecessary when running
        (only used when compiling).
      
        Instead use `have_pvplugin_support` function in paraviewFunctions
        wmake script to determine the maj.min from the PV_PLUGIN_PATH
        since we have already defined the output path there with paraview
        maj.min numbering.
      
        Can now build with paraview from the operating system,
        provided that it has develop headers available.
      
            ParaView_VERSION=system
      
        In the etc/config.sh/paraview setup, the maj.min is taken from
        the corresponding `paraview --version` output and used when
        defining the PV_PLUGIN_PATH.
      
        During the build, the include path taken from `paraview-config`
        for a system installation, from the guess installation root
        of the paraview binary, or ParaView_DIR otherwise.
      
      NB: using a system ParaView for building runTimePostProcessing is unsupported.
      
      - these types of builds appear to have various library resolution issues
        (eg, libexpat not being loaded). Additionally, the build logic does
        not yet cover this type of use case.
      628b2445
  11. Nov 28, 2018
    • Mark OLESEN's avatar
      STYLE: typo in comments · dd0487ac
      Mark OLESEN authored
      dd0487ac
    • Mark OLESEN's avatar
      ENH: add regular expressions for reconstructPar, mapFieldsPar -fields option · 41a03f37
      Mark OLESEN authored
      - improved flexibility
      
      - reconstruction of Lagrangian positions/fields now handled as a class
        for better modularity
      41a03f37
    • Mark OLESEN's avatar
      ENH: additional variants of IOobjectList findObject() · b81420e5
      Mark OLESEN authored
      - cfindObject() for const pointer access.
      
      - getObject() for mutable non-const pointer access, similar to the
           objectRegistry::getObjectPtr()
      
      - cfindObject(), findObject(), getObject() with template type access
        to also check the headerClassName.
      
        For example,
      
            cfindObject("U")  ->  good
            cfindObject<volVectorField>("U") -> good
            cfindObject<volScalarField>("U") -> nullptr
      
        This allows inversion of looping logic.
      
          1) Obtain the names for a particular Type
      
             for (const word& objName : objs.sortedNames<Type>())
             {
                 const IOobject* io = objs[objName];
                 ...
             }
      
          2) Use previously obtained names and apply to a particular Type
      
             for (const word& objName : someListOfNames)
             {
                 const IOobject* io = objs.cfindObject<Type>(objName);
                 if (io)
                 {
                     ...
                 }
             }
      b81420e5
    • Mark OLESEN's avatar
      STYLE: const-correctness on IOobject* access · 74774591
      Mark OLESEN authored
      - foamToEnsight, foamToEnsightParts, profiling
      74774591
  12. Nov 27, 2018
  13. Nov 25, 2018
  14. Nov 24, 2018
  15. Nov 23, 2018
    • Mark OLESEN's avatar
      BUG: errors found in feature-vtm merge !213 · 05353da5
      Mark OLESEN authored
      - vtkWrite with moving mesh was not updated the subsets properly,
        which caused it to crash.
      
      - foamToVTK -overwrite ignored for single region cases,
        was working for multi-region cases
      
      - minor documentation changes
      05353da5
  16. Nov 14, 2018
  17. Nov 23, 2018
  18. Nov 22, 2018