- Dec 15, 2016
-
-
Andrew Heather authored
-
- Oct 07, 2016
-
-
Andrew Heather authored
-
- Sep 19, 2016
-
-
Henry Weller authored
solvers: Moved createRDeltaT.H into createFields.H so that it is available with the -postProcess option Required to support LTS with the -postProcess option with sub-models dependent on ddt terms during construction, in particular reactingTwoPhaseEulerFoam.
-
- May 09, 2016
-
-
Henry Weller authored
See also commit cc455173
-
- May 08, 2016
-
-
Henry Weller authored
See also commit cc455173
-
Henry Weller authored
See also commit cc455173 Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1301
-
- Apr 30, 2016
-
-
Henry Weller authored
-
Henry Weller authored
GeometricField: Renamed internalField() -> primitiveField() and dimensionedInternalField() -> internalField() These new names are more consistent and logical because: primitiveField(): primitiveFieldRef(): Provides low-level access to the Field<Type> (primitive field) without dimension or mesh-consistency checking. This should only be used in the low-level functions where dimensional consistency is ensured by careful programming and computational efficiency is paramount. internalField(): internalFieldRef(): Provides access to the DimensionedField<Type, GeoMesh> of values on the internal mesh-type for which the GeometricField is defined and supports dimension and checking and mesh-consistency checking.
-
Henry Weller authored
In order to simplify expressions involving dimensioned internal field it is preferable to use a simpler access convention. Given that GeometricField is derived from DimensionedField it is simply a matter of de-referencing this underlying type unlike the boundary field which is peripheral information. For consistency with the new convention in "tmp" "dimensionedInteralFieldRef()" has been renamed "ref()".
-
- Apr 28, 2016
-
-
Henry Weller authored
When the GeometricBoundaryField template class was originally written it was a separate class in the Foam namespace rather than a sub-class of GeometricField as it is now. Without loss of clarity and simplifying code which access the boundary field of GeometricFields it is better that GeometricBoundaryField be renamed Boundary for consistency with the new naming convention for the type of the dimensioned internal field: Internal, see commit 4a57b9be This is a very simple text substitution change which can be applied to any code which compiles with the OpenFOAM-dev libraries.
-
- Apr 26, 2016
-
-
Henry Weller authored
See also commit 22f4ad32
-
- Apr 25, 2016
-
-
Henry Weller authored
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1938 Because C++ does not support overloading based on the return-type there is a problem defining both const and non-const member functions which are resolved based on the const-ness of the object for which they are called rather than the intent of the programmer declared via the const-ness of the returned type. The issue for the "boundaryField()" member function is that the non-const version increments the event-counter and checks the state of the stored old-time fields in case the returned value is altered whereas the const version has no side-effects and simply returns the reference. If the the non-const function is called within the patch-loop the event-counter may overflow. To resolve this it in necessary to avoid calling the non-const form of "boundaryField()" if the results is not altered and cache the reference outside the patch-loop when mutation of the patch fields is needed. The most straight forward way of resolving this problem is to name the const and non-const forms of the member functions differently e.g. the non-const form could be named: mutableBoundaryField() mutBoundaryField() nonConstBoundaryField() boundaryFieldRef() Given that in C++ a reference is non-const unless specified as const: "T&" vs "const T&" the logical convention would be boundaryFieldRef() boundaryFieldConstRef() and given that the const form which is more commonly used is it could simply be named "boundaryField()" then the logical convention is GeometricBoundaryField& boundaryFieldRef(); inline const GeometricBoundaryField& boundaryField() const; This is also consistent with the new "tmp" class for which non-const access to the stored object is obtained using the ".ref()" member function. This new convention for non-const access to the components of GeometricField will be applied to "dimensionedInternalField()" and "internalField()" in the future, i.e. "dimensionedInternalFieldRef()" and "internalFieldRef()".
-
- Apr 06, 2016
-
-
Henry Weller authored
e.g. (fvc::interpolate(HbyA) & mesh.Sf()) -> fvc::flux(HbyA) This removes the need to create an intermediate face-vector field when computing fluxes which is more efficient, reduces the peak storage and improved cache coherency in addition to providing a simpler and cleaner API.
-
- Feb 29, 2016
-
-
Henry Weller authored
-
- Feb 26, 2016
-
-
Henry Weller authored
The deprecated non-const tmp functionality is now on the compiler switch NON_CONST_TMP which can be enabled by adding -DNON_CONST_TMP to EXE_INC in the Make/options file. However, it is recommended to upgrade all code to the new safer tmp by using the '.ref()' member function rather than the non-const '()' dereference operator when non-const access to the temporary object is required. Please report any problems on Mantis. Henry G. Weller CFD Direct.
-
- Feb 18, 2016
-
-
Henry Weller authored
Avoids problems with inherited complex BCs for which the controlling fields and parameters are not initialized.
-
- Feb 13, 2016
-
-
Henry Weller authored
The boundary conditions of HbyA are now constrained by the new "constrainHbyA" function which applies the velocity boundary values for patches for which the velocity cannot be modified by assignment and pressure extrapolation is not specified via the new "fixedFluxExtrapolatedPressureFvPatchScalarField". The new function "constrainPressure" sets the pressure gradient appropriately for "fixedFluxPressureFvPatchScalarField" and "fixedFluxExtrapolatedPressureFvPatchScalarField" boundary conditions to ensure the evaluated flux corresponds to the known velocity values at the boundary. The "fixedFluxPressureFvPatchScalarField" boundary condition operates exactly as before, ensuring the correct flux at fixed-flux boundaries by compensating for the body forces (gravity in particular) with the pressure gradient. The new "fixedFluxExtrapolatedPressureFvPatchScalarField" boundary condition may be used for cases with or without body-forces to set the pressure gradient to compensate not only for the body-force but also the extrapolated "HbyA" which provides a second-order boundary condition for pressure. This is useful for a range a problems including impinging flow, extrapolated inlet conditions with body-forces or for highly viscous flows, pressure-induced separation etc. To test this boundary condition at walls in the motorBike tutorial case set lowerWall { type fixedFluxExtrapolatedPressure; } motorBikeGroup { type fixedFluxExtrapolatedPressure; } Currently the new extrapolated pressure boundary condition is supported for all incompressible and sub-sonic compressible solvers except those providing implicit and tensorial porosity support. The approach will be extended to cover these solvers and options in the future. Note: the extrapolated pressure boundary condition is experimental and requires further testing to assess the range of applicability, stability, accuracy etc. Henry G. Weller CFD Direct Ltd.
-
- Jan 10, 2016
-
-
Henry Weller authored
-
- Dec 03, 2015
-
-
Andrew Heather authored
-
- Dec 02, 2015
-
-
Henry Weller authored
fvOptions are transferred to the database on construction using fv::options::New which returns a reference. The same function can be use for construction and lookup so that fvOptions are now entirely demand-driven. The abstract base-classes for fvOptions now reside in the finiteVolume library simplifying compilation and linkage. The concrete implementations of fvOptions are still in the single monolithic fvOptions library but in the future this will be separated into smaller libraries based on application area which may be linked at run-time in the same manner as functionObjects.
-
- Dec 01, 2015
-
-
Henry Weller authored
See also commit 52d83407
-
- Nov 10, 2015
-
-
Henry Weller authored
Avoids the clutter and maintenance effort associated with providing the function signature string.
-
- Sep 11, 2015
-
-
Henry Weller authored
-
- Jul 21, 2015
-
-
Henry Weller authored
to simplify construction of dimensionedScalar properties and avoid the duplication of the name string in the constructor call.
-
- Jul 20, 2015
-
-
Henry Weller authored
so that the specification of the name and dimensions are optional in property dictionaries. Update tutorials so that the name of the dimensionedScalar property is no longer duplicated but optional dimensions are still provided and are checked on read.
-
- Jul 19, 2015
-
-
Henry Weller authored
-
- Jul 15, 2015
-
-
Henry Weller authored
Added calls to setFluxRequired for p, p_rgh etc. in all solvers which avoids the need to add fluxRequired entries in fvSchemes dictionaries.
-
- Jun 28, 2015
-
-
Henry Weller authored
Now the specification of the LTS time scheme is simply: ddtSchemes { default localEuler; }
-
- Jun 26, 2015
-
-
Henry Weller authored
-
Henry Weller authored
-
Henry Weller authored
LTS is selected by the ddt scheme e.g. in the tutorials/multiphase/interFoam/ras/DTCHull case: ddtSchemes { default localEuler rDeltaT; } LTSInterFoam is no longer needed now that interFoam includes LTS support.
-
- Jun 16, 2015
-
-
Henry Weller authored
-
- May 29, 2015
-
-
Henry authored
fvOptions does not have the appropriate structure to support MRF as it is based on option selection by user-specified fields whereas MRF MUST be applied to all velocity fields in the particular solver. A consequence of the particular design choices in fvOptions made it difficult to support MRF for multiphase and it is easier to support frame-related and field related options separately. Currently the MRF functionality provided supports only rotations but the structure will be generalized to support other frame motions including linear acceleration, SRF rotation and 6DoF which will be run-time selectable.
-
- Apr 29, 2015
-
-
Henry authored
nLimiterIter: Number of iterations during limiter construction 3 (default) is sufficient for 3D simulations with a Courant number 0.5 or so For larger Courant numbers larger values may be needed but this is only relevant for IMULES and CMULES smoothLimiter: Coefficient to smooth the limiter to avoid "diamond" staggering patters seen in regions of low particle phase-fraction in fluidised-bed simulations. The default is 0 as it is not needed for all simulations. A value of 0.1 is appropriate for fluidised-bed simulations. The useful range is 0 -> 0.5. Values larger than 0.5 may cause excessive smearing of the solution.
-
- Apr 20, 2015
-
-
Henry authored
Resolves bug-report http://openfoam.org/mantisbt/view.php?id=1665
-
- Mar 19, 2015
-
-
Henry authored
-
- Mar 17, 2015
-
-
Henry authored
Allows the specification of a reference height, for example the height of the free-surface in a VoF simulation, which reduces the range of p_rgh. hRef is a uniformDimensionedScalarField specified via the constant/hRef file, equivalent to the way in which g is specified, so that it can be looked-up from the database. For example see the constant/hRef file in the DTCHull LTSInterFoam and interDyMFoam cases.
-
- Feb 22, 2015
- Feb 21, 2015
-
-
Henry authored
-