Will Bainbridge authored 7 years ago and Andrew Heather committed 7 years ago

A lot of methods were taking argument data which could be referenced or
generated from the parcel class at little or no additional cost. This
was confusing and generated the possibility of inconsistent data states.

Will Bainbridge authored 7 years ago and Andrew Heather committed 7 years ago

Tracking data classes are no longer templated on the derived cloud type.
The advantage of this is that they can now be passed to sub models. This
should allow continuous phase data to be removed from the parcel
classes. The disadvantage is that every function which once took a
templated TrackData argument now needs an additional TrackCloudType
argument in order to perform the necessary down-casting.

Will Bainbridge authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug report https://bugs.openfoam.org/view.php?id=2680

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2677

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

The combined solver includes the most advanced and general functionality from
each solver including:

    Continuous phase
    Lagrangian multiphase parcels
    Optional film
    Continuous and Lagrangian phase reactions
    Radiation
    Strong buoyancy force support by solving for p_rgh

The reactingParcelFoam and reactingParcelFilmFoam tutorials have been combined
and updated.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Description
    The Foam::Function1 temperature-dependent viscosity model multiplies the
    viscosity of a base model by a Function1 temperature function.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2605

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

for consistency with reactingTwoPhaseEulerFoam and to ensure correct operation
of models requiring formal boundedness of phase-fractions.

Resolves bug-report https://bugs.openfoam.org/view.php?id=2589

INT: updated overInterDyMFoam and MPPICInterFoam following changes to multiphase solvers.  Needs further testing

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

using the continuity error correction formulation developed for
twoPhaseEulerFoam and reactingEulerFoam.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2632

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2629

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Temporal variation of Ta is generally more useful than spatial variation but
a run-time switch between the two modes of operation could be implemented in
needed.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

"pos" now returns 1 if the argument is greater than 0, otherwise it returns 0.
This is consistent with the common mathematical definition of the "pos" function:

https://en.wikipedia.org/wiki/Sign_(mathematics)

However the previous implementation in which 1 was also returned for a 0
argument is useful in many situations so the "pos0" has been added which returns
1 if the argument is greater or equal to 0.  Additionally the "neg0" has been
added which returns 1 if if the argument is less than or equal to 0.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Now the "localEuler" ddt scheme does not apply any corrections due to
mesh-motion; the old-time volumes are not used and the mesh-motion flux is set
to zero.  A consequence of these changes is that boundedness of transported
scalars is ensured but mesh-motion causes a conservation error which will
reduces to zero as steady-state is approached and the mesh becomes stationary.

mattijs authored 7 years ago and Andrew Heather committed 7 years ago

Patch contributed by Mattijs Janssens
Resolves bug-report https://bugs.openfoam.org/view.php?id=2621

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Patch Contributed by Karl Meredith, FM Global.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2621

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Avoids potential problems with derived classes which do not define a clone function.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2667

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Patch contributed by Timo Niemi, VTT.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2645