Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 424
    • Issues 424
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Merge requests
  • !393

ENH: BilgerMixtureFraction: New function object

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kutalmış Berçin requested to merge feature-Bilger-mixture-fraction-fo into develop Nov 20, 2020
  • Overview 3
  • Commits 4
  • Changes 32

Summary

A contribution by a community member, @g3.

See #1915 (closed)

Details of new models (If applicable)

See #1915 (comment 49598)

Risks

N/A

WIP issues

  • The FO needs info from specieComposition(): see the line
  • The function can be called through ThermoType (i.e. thermoPhysicsTypes.H), but there are too many template-template classes thereat. This would create a very long and thus annoyingly redundant piece of repeating code.
  • Instead, ReactionThermo could be used. But ReactionThermo does not have access to the info. Even in TDACChemistryModel, specieComposition was fetched through ThermoType.
    • Note that if ReactionThermo is used, some solvers may not run the FO.

Bat-signal: @andy @Sergio

Edited Dec 14, 2020 by Kutalmış Berçin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature-Bilger-mixture-fraction-fo