ENH: interpolate in cylindrical coordinates: See #2145
This intercepts all vector/tensor AMI interpolations and does the interpolation in cylindrical coordinates.
Use (component) 'coupled' linear solver to enable this in the linear solver sweeps as well (however this is not very stable since the vector solution is still in Cartesian coordinates - only the AMI interpolation is in cylindrical)
Merge request reports
Activity
requested review from @kuti
assigned to @andy
added 7 commits
-
bc3eaefc...fa03050e - 2 commits from branch
develop
- 82d4014f - ENH: interpolate in cylindrical coordinates: See #2145 (closed)
- 1c2cff13 - BUG: momentum: angularVelocity zero on boundary. Fixes #2157 (closed).
- 2e4a1044 - BUG: cyclicPeriodicAMI: incorrect faceCentres. See #2145 (closed)
- c91558dc - BUG: cyclicPeriodicAMI: consistent use of interpolation. See #2145 (closed)
- ec0a813d - BUG: cyclicPeriodicAMI: some more logic. See #2145 (closed)
Toggle commit list-
bc3eaefc...fa03050e - 2 commits from branch
I got a compilation error from a git-clone-based (i.e. clean) compilation. Attached a reduced log.
Could you confirm whether you get the same error?
base0 = work base1 = compilationTest api = 2107 patch = 0 HEAD = ec0a813 version = com compiler = Gcc (system) = gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39) mpi = SYSTEMOPENMPI = mpirun (Open MPI) 4.0.3 OS = Description: CentOS Linux release 7.7.1908 (Core) labels = 32 opts = linux64GccDPInt32Opt
added 12 commits
- 3767dc7e - ENH: KirchhoffShell: simplification of log output
- 74b11627 - TUT: rotatingFanInRoom: perturb locationInMesh (fixes #2162 (closed))
- 51732b04 - ENH: linear solvers: add variable-specific debug flags
- b7215610 - BUG: DMD: write snapshot0 at start times (fixes #2122 (closed))
- 8930b314 - TUT: hopper: parameterise blockMeshDict content (#2134 (closed))
- d06c320b - ENH: makeSolidReaction: modify macros to allow new models
- 09b2df48 - BUG: turbulenceFields: use omega funcs of turbulence models (fixes #2132 (closed))
- 0ce6f40d - STYLE: turbulenceFields: apply more recent OpenFOAM-coding practices
- 04a20216 - DOC: turbulenceFields: improve header documentation
- 706e5e96 - BUG: turbulenceFields: unset duplicate already-registered fields
- 7d51cbfe - ENH: turbulenceFields: enable custom prefix for output fields
- 09b81b68 - Implicit treatment of coupled boundary conditions
Toggle commit listadded 20 commits
-
09b81b68...c8a52fad - 14 commits from branch
develop
- 9b49bc97 - ENH: interpolate in cylindrical coordinates: See #2145 (closed)
- 689c5427 - BUG: momentum: angularVelocity zero on boundary. Fixes #2157 (closed).
- 2b4d40a5 - BUG: cyclicPeriodicAMI: incorrect faceCentres. See #2145 (closed)
- 2c81f867 - BUG: cyclicPeriodicAMI: consistent use of interpolation. See #2145 (closed)
- 9a9e0043 - BUG: cyclicPeriodicAMI: some more logic. See #2145 (closed)
- fd553490 - Implicit treatment of coupled boundary conditions
Toggle commit list-
09b81b68...c8a52fad - 14 commits from branch
changed title from ENH: interpolate in cylindrical coordinates: See #2145 (closed) to WIP : ENH: interpolate in cylindrical coordinates: See #2145 (closed)
In hindsight:
- proposed fix adds complete copy of cyclicAMI wrappers (pointPatches, pointPatchFields, fvsPatchFields, fvPatch etc) only to be able to override the basic interpolation.
- still does not solve the problem of preserving the actual rotation matrix so will not enable e.g. tracking, wall distance etc.
- so instead stick with current way (cyclicPeriodicAMI = preprocessor on cyclicAMI) and build in switch inside cyclicAMI to do any interpolation in cylindrical coords. By default it is false but cyclicPeriodicAMI can set it. (or even the user can?)
added 5 commits
-
fd553490...b78dccdd - 4 commits from branch
develop
- f2068a24 - ENH: interpolate in cylindrical coordinates: See #2145 (closed)
-
fd553490...b78dccdd - 4 commits from branch
changed title from WIP : ENH: interpolate in cylindrical coordinates: See #2145 (closed) to ENH: interpolate in cylindrical coordinates: See #2145 (closed)
changed milestone to %v2112
added AMI-related enhancement labels
added 45 commits
-
f2068a24...7c46daea - 44 commits from branch
develop
- 0a2d9f10 - ENH: interpolate in cylindrical coordinates: See #2145 (closed)
-
f2068a24...7c46daea - 44 commits from branch
added 2 commits
-
c0feb565 - 1 commit from branch
develop
- a4289f7d - ENH: interpolate in cylindrical coordinates: See #2145 (closed)
-
c0feb565 - 1 commit from branch
mentioned in commit 72e67c7d