refactor coordSet writers (#2347)
Summary
Replace old, stateless, templated writer class with a coordSetWriter class that more closely resembles surfaceWriter. It is time-aware and can be used as a streamer with sample/write of each field instead of accumulating all of the sampled fields ahead of time.
Merge request reports
Activity
changed milestone to %v2206
added enhancement feature labels
assigned to @andy
@andy and @THO - ready for some testing.
Note: already updated develop branch with various adjustments to allow this changeset as a single atomic commit without too many peripheral changes.
mentioned in issue #2358 (closed)
added 16 commits
-
47f757a7...5386dd56 - 15 commits from branch
develop
- 93e673ea - ENH: refactor coordSet writers (#2347 (closed))
-
47f757a7...5386dd56 - 15 commits from branch
added 4 commits
-
93e673ea...fcb32833 - 3 commits from branch
develop
- a056f544 - ENH: refactor coordSet writers (#2347 (closed))
-
93e673ea...fcb32833 - 3 commits from branch
Thanks for resolving @mark. Test are starting as soon as I have the branch ready at the client´s server.
@mark, simply by using e.g., a set cloud while tracking the pressure field and use the data in a valueAveraging FO. E.g., see EP1808 or maybe better (with an example of the simpleCar tutorial) EP1657
Edited by Mark OLESENmentioned in issue #2388 (closed)
added 17 commits
-
a056f544...b94ffe93 - 13 commits from branch
develop
- aa5db904 - ENH: refactor coordSet writers (#2347 (closed))
- 8871a67c - ENH: ensemble results for sampleSets (#2388 (closed))
- ccbb614d - TUT: update tutorials to use dictionary-style sets
- 34e8c1a5 - ENH: support 'probes' style of ensemble output for sampledSets (#2389 (closed))
Toggle commit list-
a056f544...b94ffe93 - 13 commits from branch
@andy - resolved features/misfeatures based on @THO feedback. Ready to go.
@mark, I tested your new developments and everything works fine.
- stop writing data but still execute the sampling works
- saving the sets data in a single file by using setFormat probes
- the averaging of the single sets inside another FO such as valueAverage works (
fields (average(<setName>,p))
) - the averaging of the ensemble data of all sets inside another FO such as valueAverage works (
fields (average(p))
)
Thanks for your effort and development. @andy, from my side everything is fine.
Edited by Tobias Holzmannadded 35 commits
-
34e8c1a5...8a9ae839 - 31 commits from branch
develop
- c3e14ffd - ENH: refactor coordSet writers (#2347 (closed))
- 87db3ce4 - ENH: ensemble results for sampleSets (#2388 (closed))
- 8a7221cf - TUT: update tutorials to use dictionary-style sets
- 010ebadb - ENH: support 'probes' style of ensemble output for sampledSets (#2389 (closed))
Toggle commit list-
34e8c1a5...8a9ae839 - 31 commits from branch
@andy - manually rebased.