ENH: processorFaPatch: use internal-edge algos for processor edges to ensure parallel consistency (!708) · Merge requests · Development / openfoam

Merged ENH: processorFaPatch: use internal-edge algos for processor edges to ensure parallel consistency

fa-parallel-consistency-improvements into develop

Merged Kutalmış Berçin requested to merge fa-parallel-consistency-improvements into develop 6 months ago

Case index	Planar	Equidistant	Skewness/Non-orthogonality
Case 1	Yes	Yes	Zero
Case 2	Yes	No	Zero
Case 3	Yes	Yes	Non-zero
Case 4	Yes	No	Non-zero
Case 5	No (45deg)	Yes	Zero
Case 6	No (45deg)	No	Zero
Case 7	No (45deg)	No	Non-zero
Case 8	No (60deg)	No	Non-zero

Dec 19, 2024

ENH: processorFaPatch: use internal-edge algos for processor edges to ensure parallel consistency · 2d731e1a

Kutalmış Berçin authored 6 months ago and

Andrew Heather committed 4 months ago

- The edgeInterpolation::makeCorrectionVectors() disables the non-orthogonality
correction if the calculated non-orthogonality coefficient is below 0.1.
However, this activation routine only considers internal edges, and excludes
any processor edges, resulting in inconsistent parallel calculations. This
routine is removed.
- Fatal errors are replaced with zero-valued fields for non-orthogonality-
and skewness-correction routines.

2d731e1a

ENH: processorFaPatch: use internal-edge algos for processor edges to ensure parallel consistency

Summary

Case 1

Case 2

Case 3

Case 4

Case 5

Case 6

Case 7

Case 8

Resolved bugs

Chair case

Risks

Metadata

`cylinder`

`drippingChair`

`filmPanel0`

`hotRoomWithThermalShell`

`inclinedPlaneFilm`

`liquidFilmStepWithSprinklers`

`pitzDailyWithSprinklers`

`planeTransport`

`sloshing2D`

`sphereTransport`

`splashPanelFilm`

Activity

Admin message

ENH: processorFaPatch: use internal-edge algos for processor edges to ensure parallel consistency

Summary

Case 1

Case 2

Case 3

Case 4

Case 5

Case 6

Case 7

Case 8

Resolved bugs

Chair case

Risks

Metadata

cylinder

drippingChair

filmPanel0

hotRoomWithThermalShell

inclinedPlaneFilm

liquidFilmStepWithSprinklers

pitzDailyWithSprinklers

planeTransport

sloshing2D

sphereTransport

splashPanelFilm

Merge request reports

Activity

`cylinder`

`drippingChair`

`filmPanel0`

`hotRoomWithThermalShell`

`inclinedPlaneFilm`

`liquidFilmStepWithSprinklers`

`pitzDailyWithSprinklers`

`planeTransport`

`sloshing2D`

`sphereTransport`

`splashPanelFilm`