ENH: improve code consistency for {cell,face,point}Mapper (#3147)
- robuster and more reliable determination of inserted objects (previous code could produce false positives). Now also determine the number of inserted objects within the constructor (instead of simply storing a bool). This allows reuse in the address calculations to reduce overheads there. BUG: dodgy short-circuit logic for insertedObjectLabels() - as a quick short-circuit it previously created as demand-driven pointer with a zero elements. However, this meant that if this code was called first (before any other addressing), subsequent calls to the addressing would fail. BUG: bad logic and lookup for faAreaMapper (#3147) - was using labelHashSet but returning a bool and set using the addressing using the unfiltered objects! This is a latent bug since interpolated/inserted faces not currently supported anyhow. ENH: use std::unique_ptr for demand-driven data
parent
8a8b5db9
Showing
- src/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointBoundaryMeshMapper.H 2 additions, 2 deletions...eshes/pointMesh/pointMeshMapper/pointBoundaryMeshMapper.H
- src/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointMapper.C 175 additions, 121 deletionssrc/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointMapper.C
- src/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointMapper.H 28 additions, 30 deletionssrc/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointMapper.H
- src/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointMeshMapper.H 8 additions, 9 deletions...enFOAM/meshes/pointMesh/pointMeshMapper/pointMeshMapper.H
- src/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointPatchMapper.C 26 additions, 28 deletions...nFOAM/meshes/pointMesh/pointMeshMapper/pointPatchMapper.C
- src/OpenFOAM/meshes/pointMesh/pointMeshMapper/pointPatchMapper.H 9 additions, 12 deletions...nFOAM/meshes/pointMesh/pointMeshMapper/pointPatchMapper.H
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/cellMapper/cellMapper.C 205 additions, 226 deletions...nFOAM/meshes/polyMesh/mapPolyMesh/cellMapper/cellMapper.C
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/cellMapper/cellMapper.H 26 additions, 29 deletions...nFOAM/meshes/polyMesh/mapPolyMesh/cellMapper/cellMapper.H
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/faceMapper/faceMapper.C 180 additions, 167 deletions...nFOAM/meshes/polyMesh/mapPolyMesh/faceMapper/faceMapper.C
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/faceMapper/faceMapper.H 25 additions, 29 deletions...nFOAM/meshes/polyMesh/mapPolyMesh/faceMapper/faceMapper.H
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/mapPolyMesh.C 1 addition, 1 deletionsrc/OpenFOAM/meshes/polyMesh/mapPolyMesh/mapPolyMesh.C
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/mapPolyMesh.H 48 additions, 46 deletionssrc/OpenFOAM/meshes/polyMesh/mapPolyMesh/mapPolyMesh.H
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/objectMap/objectMap.H 31 additions, 18 deletions...penFOAM/meshes/polyMesh/mapPolyMesh/objectMap/objectMap.H
- src/OpenFOAM/meshes/polyMesh/mapPolyMesh/objectMap/objectMapI.H 9 additions, 35 deletions...enFOAM/meshes/polyMesh/mapPolyMesh/objectMap/objectMapI.H
- src/finiteArea/faMesh/faMeshMapper/faAreaMapper.C 86 additions, 158 deletionssrc/finiteArea/faMesh/faMeshMapper/faAreaMapper.C
- src/finiteArea/faMesh/faMeshMapper/faAreaMapper.H 17 additions, 17 deletionssrc/finiteArea/faMesh/faMeshMapper/faAreaMapper.H
- src/finiteArea/faMesh/faMeshMapper/faBoundaryMeshMapper.H 2 additions, 2 deletionssrc/finiteArea/faMesh/faMeshMapper/faBoundaryMeshMapper.H
- src/finiteArea/faMesh/faMeshMapper/faEdgeMapper.C 15 additions, 10 deletionssrc/finiteArea/faMesh/faMeshMapper/faEdgeMapper.C
- src/finiteArea/faMesh/faMeshMapper/faEdgeMapper.H 24 additions, 23 deletionssrc/finiteArea/faMesh/faMeshMapper/faEdgeMapper.H
- src/finiteArea/faMesh/faMeshMapper/faMeshMapper.C 7 additions, 3 deletionssrc/finiteArea/faMesh/faMeshMapper/faMeshMapper.C
Please register or sign in to comment