Skip to content
Snippets Groups Projects
  1. Nov 28, 2020
  2. Nov 26, 2020
  3. Nov 25, 2020
    • Mark OLESEN's avatar
      ENH: installation helpers · 9fe09ad2
      Mark OLESEN authored
      ----
      install-dirs: a general directory installer
      
        Copy installs non-binary (platform) directories.
        Eg,
      
            install-dirs -prefix=... -devel
            install-dirs -prefix=... -default -no-app
      
      ----
      install-platform: a platform (binary) installer
      
        This is primarily driven by the need to install into system mpi
        directories. The problem noted in issue #1893 is caused by the
        rpm-mpi-hooks (fedora and redhat-8).
      
        For the additional mpi library qualifier (openmpi-x86_64) to be
        added to the requirements, the mpi-specific libraries (eg,
        libPstream.so) need to be installed in the mpi system directory
        (eg, /usr/lib64/openmpi).
      
        However, then need symlinks from the system locations back to our
        local directories to ensure that the libraries are correctly found
        via our LD_LIBRARY_PATH and we don't get dummy libraries.
      
      ----
      update-mpi-links: a post-install update hook
      
        Expected paths are registered as persistent information into the
        hook during packaging. Triggering the hook after installation
        completes the creation of the symlinks.
      
      Normal usage,
      ```
      prefix="/tmp/local-install/openfoam"
      
      bin/tools/install-dirs -prefix="$prefix" -common
      bin/tools/install-platform -prefix="$prefix"
      ```
      Installs
       - /tmp/local-install/openfoam/META-INFO
       - /tmp/local-install/openfoam/bin
       - /tmp/local-install/openfoam/etc
       - /tmp/local-install/openfoam/platforms/linux64GccDPInt32Opt/bin
       - /tmp/local-install/openfoam/platforms/linux64GccDPInt32Opt/lib
      
      Can also place architecture-dependent bits elsewhere,
      ```
      prefix="/tmp/local-install/openfoam"
      multi_arch="$(dpkg-architecture -qDEB_TARGET_MULTIARCH)"
      
      bin/tools/install-dirs -prefix="$prefix" -common
      bin/tools/install-platform -exec-prefix="$prefix/$multi_arch"
      ```
      Installs
       - /tmp/local-install/openfoam/META-INFO
       - /tmp/local-install/openfoam/bin
       - /tmp/local-install/openfoam/etc
       - /tmp/local-install/openfoam/x86_64-linux-gnu/bin
       - /tmp/local-install/openfoam/x86_64-linux-gnu/lib
      
      Can use it to flatten out platforms entirely,
      ```
      prefix="/tmp/local-install/openfoam"
      bin/tools/install-dirs -prefix="$prefix" -common
      bin/tools/install-platform -exec-prefix="$prefix"
      ```
      Installs
       - /tmp/local-install/openfoam/META-INFO
       - /tmp/local-install/openfoam/bin
       - /tmp/local-install/openfoam/etc
       - /tmp/local-install/openfoam/lib
      9fe09ad2
    • Mark OLESEN's avatar
      CONFIG: bump API to 2011 · c2bf9e1c
      Mark OLESEN authored
      - mostly to reflect changes in config prefs and output methods
      c2bf9e1c
    • Mark OLESEN's avatar
    • Mark OLESEN's avatar
      COMP: fix label ambiguity · 1fa4221b
      Mark OLESEN authored
      1fa4221b
    • Mark OLESEN's avatar
      ENH: consistent naming for ZoneMesh lookup method · 501cd353
      Mark OLESEN authored
      - findZone(), cfindZone() to return pointer to existing or nullptr if
        not found. This fits with methods such as findObject() etc for other
        classes and can simplify code without checks for '-1' as not found.
      
      - use simpler constructors for empty cell/face/point zones
      501cd353
    • Mark OLESEN's avatar
    • Mark OLESEN's avatar
      ENH: improve flexiblity for flat output of items (#1929) · 0de32a6e
      Mark OLESEN authored
      - change to a templated implementation instead of relying on
        the container's writeList() method.
      
        This inlines the generation while also adding the flexibility to
        define different delimiters (at compile time) without the
        performance penalty of passing run-time parameters.
      0de32a6e
    • Mark OLESEN's avatar
      ENH: align Enum methods with HashTable · d2f16905
      Mark OLESEN authored
      - deprecate get(key, deflt) in favour of lookup(key, deflt).
        Method name compatibility with HashTable.
      
      - deprecate operator().
        The meaning is too opaque and equally served by other means:
      
        - use get(key) instead of operator()(key).
          Const access whereas HashTable::operator()(key)
          creates missing entry.
      
        - lookup(key, deflt) - instead of operator()(key, deflt).
          Const access whereas HashTable::operator()(key, deflt)
          creates a missing entry.
      
      - make Enum iterable to allow participation in range-for etc.
      d2f16905
    • Mark OLESEN's avatar
      STYLE: mark deprecated findIndices methods with warnings · 9122713b
      Mark OLESEN authored
      - were deprecated Aug-2018, but not marked as such
      9122713b
    • Mark OLESEN's avatar
      STYLE: use labelRange for identity · 7349b97e
      Mark OLESEN authored
      7349b97e
    • mattijs's avatar
      ENH: improve offsets handling in extrudeToRegionMesh (#1933) · ae49b511
      mattijs authored and Mark OLESEN's avatar Mark OLESEN committed
      - non-uniform offsets are generated due to truncation errors,
        which can lead to problems later on (e.g. redistributePar).
      
        Detect if the offsets are close to being uniform.
      ae49b511
    • mattijs's avatar
      ENH: snappyHexMesh: gapLevel. See #1463. · 89ea0115
      mattijs authored
      Adds distance-to-surface as a pre-selection
      to detect cells-in-gaps. Before it could only
      use inside or outside but not distance.
      89ea0115
  4. Nov 24, 2020
  5. Nov 23, 2020
    • mattijs's avatar
      BUG: subsetMesh: map instead of truncate. See #1558. · 9c26b5ce
      mattijs authored
      This also is to do with redistributePar:
      this uses subsetMesh to generate parts to
      send to different processors.
      2) related to 1558: make sure not to choose 'mapped'
      patches to move the processor patches into so
      we can use the mapper cloning and correctly
      size additional data (e.g. offsets). This should
      be generalised to hold for any patch type
      holding local data ...
      9c26b5ce
    • mattijs's avatar
      BUG: wall distance: Fixes #1932. · f9033cbf
      mattijs authored
      Potential problem with multiple faces. Rewritten to
      use DynamicList.
      f9033cbf
    • mattijs's avatar
      COMP: Allwmake: delay building finiteArea · eaf6440a
      mattijs authored
      For convenience - build finiteVolume first
      eaf6440a
  6. Nov 20, 2020
  7. Nov 19, 2020
    • Mark OLESEN's avatar
      STYLE: fix doxygen comments · 4b964f67
      Mark OLESEN authored
      4b964f67
    • Mark OLESEN's avatar
      ENH: support frequency or period for Sine/Square Function1 (#1917) · 8d2d894a
      Mark OLESEN authored
      - For slow oscillations it can be more intuitive to specify the
        period.
      
      ENH: separate mark/space for Square
      
      - makes it easier to tailor the desired intervals.
      
      BUG: incorrect square wave fraction with negative phase shifts
      
      ENH: additional cosine Function1
      
      STYLE: avoid code duplication by inheriting Cosine/Square from Sine.
      8d2d894a
    • Mark OLESEN's avatar
      STYLE: can add compile-time deprecated message for autoPtr::set() · 6e3bc1f7
      Mark OLESEN authored
      - deprecated Feb-2018, but not marked as such.
      
        The set() method originally enforce an additional run-time check
        (Fatal if pointer was already set), but this was rarely used.
        In fact, the set() method was invariably used in constructors
        where the pointer by definition was unset.
      
        Can now mark as deprecated to catch the last of these.
        We prefer reset() for similarity with std::unique_ptr
      
        Eg,
        FOAM_EXTRA_CXXFLAGS="-DFoam_autoPtr_deprecate_setMethod"  wmake
      6e3bc1f7
    • Mark OLESEN's avatar
      ENH: Function1 and PatchFunction1 improvements (#1917) · 2f2dcdcf
      Mark OLESEN authored
      - easier support for non-mandatory functions.
      
        In some boundary conditions it can be desirable to support
        additional functions, but not necessarily require them. Make this
        easier to support with a Function1, PatchFunction1 NewIfPresent()
        selector.
      
      - support for compatibility lookups
      
      - harmonize branching logic and error handling between Function1 and
        PatchFunction1.
      
      ENH: refactor a base class for Function1, PatchFunction1
      
      - includes base characteristics, patch or scalar information
      
      ENH: additional creation macros
      
      - makeConcreteFunction1, makeConcretePatchFunction1Type for adding a
        non-templated function into the correct templated selection table.
        makeScalarPatchFunction1 for similarity with makeScalarFunction1
      2f2dcdcf
    • Mark OLESEN's avatar
      STYLE: use brace constructors for Foam::zero and Foam::one · 07bbae0c
      Mark OLESEN authored
      - makes it clearer that these are constructors and not function calls
      07bbae0c
    • Mark OLESEN's avatar
      STYLE: prefix zero/one with Foam:: qualifier · 98d05fa8
      Mark OLESEN authored
      ENH: support construction of zero-sized IndirectList
      
      - useful when addressing is to be generated in-place after construction.
        Eg,
      
            indirectPrimitivePatch myPatches
            (
                IndirectList<face>(mesh.faces(), Zero),
                mesh.points()
            );
            labelList& patchFaces = myPatches.addressing();
      
            patchFaces.resize(...);
            // populate patchFaces
      
      STYLE: add noexcept for zero/one fields and remove old dependency files
      
      COMP: correct typedefs for geometricOneField, geometricZeroField
      98d05fa8
    • Mark OLESEN's avatar
      ENH: fanPressureFvPatchScalarField - adjust compatibility handling · f126e291
      Mark OLESEN authored
      COMP: add missing clone() for fanCurve member
      
      STYLE: reduce padding in data members
      f126e291
  8. Nov 18, 2020
  9. Nov 17, 2020
  10. Nov 16, 2020