Skip to content
Snippets Groups Projects
  1. May 29, 2019
    • Mark OLESEN's avatar
      ENH: harmonize matrix constructors (#1220) · 96d0a8f2
      Mark OLESEN authored
      - generalize identity matrix constructors for non-scalar types
      
      - add constructors using labelPair for the row/column sizing information.
        For a SquareMatrix, this provides an unambiguous parameter resolution.
      
      - reuse assignment operators
      
      STYLE: adjust matrix comments
      96d0a8f2
  2. May 23, 2019
  3. Feb 03, 2019
  4. May 28, 2019
  5. Feb 10, 2019
  6. May 27, 2019
  7. May 25, 2019
    • Mark OLESEN's avatar
      COMP: force dlOpen for windows application binaries (#1238) · 66a10099
      Mark OLESEN authored
      - when windows portable executables (.exe or .dll) files are loaded,
        their dependent libraries not fully loaded. For OpenFOAM this means
        that the static constructors which are responsible for populating
        run-time selection tables are not triggered, and most of the run-time
        selectable models will simply not be available.
      
      Possible Solution
      =================
      
        Avoid this problem by defining an additional library symbol such as
        the following:
      
            extern "C" void libName_Load() {}
      
        in the respective library, and tag this symbol as 'unresolved' for
        the linker so that it will attempt to resolve it at run-time by
        loading the known libraries until it finds it. The link line would
        resemble the following:
      
            -L/some/path -llibName -ulibName_Load
      
        Pros:
          - Allows precise control of forced library loading
      
        Cons:
          - Moderately verbose adjustment of some source files (even with macro
            wrapping for the declaration).
          - Adjustment of numerous Make/options files and somewhat ad hoc
            in nature.
          - Requires additional care when implementing future libraries and/or
            applications.
      
        - This is the solution taken by the symscape patches (Richard Smith)
      
      Possible Solution
      =================
      
        Avoid this problem by simply force loading all linked libraries.
        This is done by "scraping" the information out of the respective
        Make/options file (after pre-processing) and using that to define
        the library list that will be passed to Foam::dlOpen() at run-time.
      
        Pros:
          - One-time (very) minimal adjustment of the sources and wmake toolchain
          - Automatically applies to future applications
      
        Cons:
          - Possibly larger memory footprint of application (since all dependent
            libraries are loaded).
          - Possible impact on startup time (while loading libraries)
          - More sensitive to build failures. Since the options files are
            read and modified based on the existence of the dependent
            libraries as a preprocessor step, if the libraries are initially
            unavailable for the first attempt at building the application,
            the dependencies will be inaccurate for later (successful) builds.
      
        - This is solution taken by the bluecape patches (Bruno Santos)
      
      Adopted Solution
      ================
      
        The approach taken by Bruno was adopted in a modified form since
        this appears to be the most easily maintained.
      
      Additional Notes
      ================
      
        It is always possible to solve this problem by defining a corresponding
        'libs (...)' entry in the case system/controlDict, which forces a dlOpen
        of the listed libraries. This is obviously less than ideal for large-scale
        changes, but can work to resolve an individual problem.
      
        The peldd utility (https://github.com/gsauthof/pe-util), which is
        also packaged as part of MXE could provide yet another alternative.
        Like ldd it can be used to determine the library dependencies of
        binaries or libraries. This information could be used to define an
        additional load layer for Windows.
      66a10099
  8. May 23, 2019
  9. May 22, 2019
  10. May 20, 2019
  11. May 22, 2019
    • Mark OLESEN's avatar
      ENH: improvements, modernization of matrix containers (#1220) · 061eb53f
      Mark OLESEN authored
      - add iterators, begin/end, empty() methods for STL behaviour.
        Use standard algorithms where possible
           * std::fill, std::copy
           * std::min_element, std::max_element
      
      - access methods consistent with other OpenFOAM containers:
           * data(), cdata(), uniform()
      
      - Use ListPolicy to impose output line breaks
      
      - Can recover matrix storage for re-use elsewhere.
        For example, to populate values with 2D i-j addressing and later
        release it as flat linear storage.
      
      - construct/assign moveable
      
      - added minMax() function for Matrix
      
      - additional inplace +=, -=, *=, /= operations
      
      - add named methods at() and rowData() to Matrix.
        Allows a better distinction between linear and row-based addressing
      
      - low-level matrix solve on List/UList instead of Field
      061eb53f
  12. May 21, 2019
  13. May 22, 2019
  14. May 20, 2019
  15. May 15, 2019
  16. May 22, 2019
  17. May 21, 2019
  18. May 20, 2019
  19. May 17, 2019
  20. May 21, 2019
  21. May 16, 2019
  22. May 15, 2019