Skip to content
Snippets Groups Projects
  1. Nov 15, 2016
    • Andrew Heather's avatar
      Merge branch 'externalCoupled' into 'master' · d2328f78
      Andrew Heather authored
      External coupled
      
      Improvements and bugfixes for externalCoupledFunctionObject - issues #278 #269
      
      See merge request !72
      d2328f78
    • Andrew Heather's avatar
      Merge branch 'decomposeParDict' into 'master' · b20ae1f7
      Andrew Heather authored
      BUG: resolve some decomposeParDict problems (issues #60, #265).
      
      - Cleanup/centralize handling of -decomposeParDict by relocating
        common code into argList. Ensures that all processes receive
        identical information about the -decomposeParDict opton.
      
      - Only use alternative decomposeParDict for simpleFoam/motorBike
        tutorial so that this will be included in the test loop for snappy.
      
      - Added Mattijs' fix for surfaceRedistributePar.
      
      See merge request !73
      b20ae1f7
  2. Nov 02, 2016
    • Mark Olesen's avatar
      ENH: consistent output format for coupled geometry description (issue #278) · 54c40e73
      Mark Olesen authored
      - In the corner case with few faces or points, the normal List I/O
        results in a compact list representation.
      
        This is less than desirable for external programs with simple
        line-based parsers.
      
      - Write exactly the following
      
      *Faces*
      // Patch: <word-Region> <word-Patch>
      <int-nFaces>
      (
      <int-faceSize>(<int> .. <int>)
      ...
      )
      
      *Points*
      // Patch: <word-Region> <word-Patch>
      <int-nPoints>
      (
      (<float-x> <float-y> <float-z>)
      ...
      )
      
      STYLE: only use serial form of createExternalCoupledPatchGeometry in tutorial
      
      - less confusing for the user, who wonders why it is being done twice.
      54c40e73
  3. Oct 26, 2016
  4. Oct 25, 2016
    • Mark Olesen's avatar
      BUG: resolve some decomposeParDict problems (issues #60, #265). · 52d0289e
      Mark Olesen authored
      - Cleanup/centralize handling of -decomposeParDict by relocating
        common code into argList. Ensures that all processes receive
        identical information about the -decomposeParDict opton.
      
      - Only use alternative decomposeParDict for simpleFoam/motorBike
        tutorial so that this will be included in the test loop for snappy.
      
      - Added Mattijs' fix for surfaceRedistributePar.
      52d0289e
    • Mark Olesen's avatar
      ENH: provide separate geometry description per region/patch (issue #278) · 3d5fb086
      Mark Olesen authored
      - Also fixed bug noted in issue #269
      
      - Previous implementation had all faces together, which made
        it difficult (impossible) for external applications to
        figure out which geometry was being referred to.
      
      - Provide separate region/patches as follows:
      
          // Patch: <regionName> <patchName>
      
        For example,
      
          // Group: coupleGroup
          // Patch: heater minY
          8( ... )
      
        The region-name is always present, even if there is only one region.
      
      - This change is a partial reversion to the behaviour in 2.4.x, except
        that we can now also handle multi-region geometries.
      
        Changing the leading comment from "# " to "// " facilitates parsing
        of the files with OpenFOAM itself if necessary.
      3d5fb086
    • Mark Olesen's avatar
      ENH: enable 'status=done' when finishing an externalCoupled FO · 8e2b1338
      Mark Olesen authored
      - This provides a mechanism for the external code to detect when
        OpenFOAM is done.
      
      - Adjust tutorial to use the mechanism. Also test in parallel.
      8e2b1338
  5. Oct 24, 2016
  6. Oct 19, 2016
  7. Oct 18, 2016
    • Mark Olesen's avatar
      BUG: foamCleanPath problem if path contains @ (closes #264) · 03b5d5c1
      Mark Olesen authored
      - Can occur with some user names, or mounted paths.
        Resolve by using '?' for the separation character.
      
        Since '?' is a shell-glob, it is highly unlikely to occur appear in
        filenames.  Additionally, it is not a meta-character in standard sed,
        nor in the GNU extension (which uses '\?').
      03b5d5c1
  8. Oct 17, 2016
  9. Oct 04, 2016
  10. Oct 03, 2016
    • Mark Olesen's avatar
      ENH: provide direct access to raw pointer/reference from autoPtr (issue #252) · 96c3a090
      Mark Olesen authored
      All of the access methods for autoPtr include validity checks and will
      fail if the underlying point is NULL. In some cases, however, we'd
      like to retain the automatic deletion mechanism, but still address a
      nullptr. This is mostly for cases in which a file-stream should be
      allocated, but only on the master process. For these cases we'd still
      like to pass through and reference the underlying pointer (eg, to
      obtain the correct method call) without tripping the pointer check
      mechanism. If we attempt to use the ptr() method, the autoPtr memory
      management is bypassed and we risk memory leaks.
      
      Instead provide an alternative mechanism to obtain the raw underlying
      pointers/references. Use rawPtr() and rawRef() for these potentially
      useful, but also potentially dangerous, operations.
      96c3a090
    • mattijs's avatar
  11. Sep 30, 2016
  12. Sep 29, 2016
  13. Sep 28, 2016
  14. Sep 27, 2016
  15. Sep 26, 2016
  16. Sep 23, 2016