Skip to content
Snippets Groups Projects
  1. Nov 13, 2016
    • Mark Olesen's avatar
      ENH: simplify check for metis sizes (issue #290) · 704620ae
      Mark Olesen authored
      - Now that the metisDecomp uses the metis definition for float/double,
        do not need to verify the scalar sizes.
      
      Note:
      - could drop precision qualifier for metis, scotch installation
        (include, lib) as being unneeded, but it is simpler to keep them
        and continue to use the FOAM_EXT_LIBBIN path
        (in case other ThirdParty software is compiled with different
        precisions).
      704620ae
  2. Nov 11, 2016
  3. Nov 09, 2016
    • Mark Olesen's avatar
      ENH: robuster handling of system or central installation (issue #290) · b048cacc
      Mark Olesen authored
      - Follow similar pattern as per boost/CGAL with the '*-none' to disable,
        and '*-system' for system installations.
      
        Also support central non-ThirdParty installations by specifying the
        version as "*-system", but also providing the fully qualified
        *_ARCH_PATH too.
      
      --
      ENH: Verify label and scalar sizes used in the metis header.
      
      - ensure they match with expected values, which can be obtained via
        the OpenFOAM definitions for WM_LABEL_SIZE and WM_PRECISION_OPTION
      b048cacc
  4. Nov 04, 2016
    • Mark Olesen's avatar
      COMP: Newer CGAL versions break current CGAL wmake rules (issue #288) · e8f6099a
      Mark Olesen authored
      On 64-bit systems, the system installations of boost, cgal are under
      lib64/. The behaviour for a ThirdParty build is mostly lib/ but this
      can also be changing.
      
          Boost 1_62_0 and older build into 'lib/'.
          CGAL-4.9 builds into 'lib64/', older versions into 'lib/'.
      
      Future-proof things by using lib$WM_COMPILER_LIB_ARCH for boost and
      cgal build rules, and forcing these as build targets in the ThirdParty
      makeCGAL as well.
      
      --
      STYLE: check for boost/version.hpp, CGAL/version.h instead their directories
      e8f6099a
  5. Oct 31, 2016
    • Mark Olesen's avatar
      CONFIG: csh not unsetting old paraview/cmake environment (related to #281) · a05493db
      Mark Olesen authored
      - On the first call, ParaView_DIR is unset and thus the clean-path
        fails with the warning "ParaView_DIR: Undefined variable."
      
        This looks messy, but is of no _major_ consequence since paraview
        doesn't need to be removed anyhow. The only slight risk is that the
        path to a third-party cmake might not be cleaned.
      
      - Patch as per Bruno's suggestion.
      a05493db
  6. Oct 28, 2016
    • Mark Olesen's avatar
      BUG: etc/bashrc incorrect behaviour if sourced locally (issue #280) · b8448671
      Mark Olesen authored
      - It is incorrect to prefix the assignment with an 'export' since this
        automatically marks the overall command as successful and circumvents
        the fallback.
      
        There is no simple way to have proper behaviour when sourced with a
        local directory path, but at least it now uses the fallback.
      
        It is still easy to wreak the mechanism with valid but confusing input.
        For example,
      
           ". /path/to/openfoam/etc/././bashrc"
      
        The only real certainty is that "${BASH_SOURCE%/*}"
        should point to the 'etc/' directory. In which case,
      
            cd ${BASH_SOURCE%/*}    # <- now in the etc/ directory
            pwd=$(pwd -P)           # <- fully-qualified path to etc/
            pwd=${pwd%/*/*}         # <- up two parent levels
      
        - This works with ". ./bashrc", but fails with ". bashrc"
          (probably not so common).
        - Con: The construct requires an additional sub-shell.
      b8448671
    • Andrew Heather's avatar
    • Mark Olesen's avatar
      053b22a9
  7. Oct 26, 2016
    • Mark Olesen's avatar
      CONFIG: remove non-POSIX use of 'type' (issue #176) · 3b96a557
      Mark Olesen authored
      - In the foundation version they introduced a construct to handle
        the transition from 'wmRefresh' as an alias to 'wmRefresh' as
        a shell function. This transition is unnecessary for OpenFOAM+
        since 1606 used wmREFRESH (not wmRefresh) as an alias.
      
        For portability it is important to avoid this non-POSIX
        "type -t". It causes issues with dash and with zsh
        (mentioned in issue #277).
      
              type -t dash  ->   -t: not found
              type -t zsh   ->  zsh: bad option: -t
      
      Note: zsh users may still noticed other problems.
      For example, the POSIX 'unset -f' normally has no output, but in zsh
      it reports an error and has exit code 1 if the function was not
      previously defined. Whereas in POSIX (including bash, dash) it only
      returns non-zero if the name(s) could not be unset.
      3b96a557
  8. Oct 09, 2016
  9. Sep 29, 2016
  10. Sep 28, 2016
  11. Sep 27, 2016
  12. Sep 09, 2016
  13. Sep 05, 2016
  14. Sep 03, 2016
  15. Aug 23, 2016
    • Henry Weller's avatar
      etc/bashrc, etc/config.sh: · c482490a
      Henry Weller authored
        - "$FOAM_USER_APPBIN" and "$FOAM_USER_LIBBIN" have been added to
          "foamOldDirs" in "etc/bashrc" and "etc/config.sh/unset"
      
        - "$OPAL_PREFIX" is now undefined in the option "SYSTEMOPENMPI" within
          "etc/config.sh/mpi", but only if the path defined in this variable
          is cleaned when using "foamCleanPath".
      
        - "$OPAL_PREFIX" is now also conditionally undefined in
          "etc/config.sh/unset" when the path is picked up by "foamCleanPath".
      
      Patch contributed by Bruno Santos
      Resolved bug-report http://bugs.openfoam.org/view.php?id=2210
      c482490a
  16. Aug 18, 2016
  17. Aug 12, 2016
  18. Aug 11, 2016
  19. Aug 05, 2016
    • Henry Weller's avatar
      C++11: Update compilation rules to specify C++11 support and conformance · 7996a913
      Henry Weller authored
      The change from C++0x to C++11 allows all of C++11 functionality to be
      used in OpenFOAM, in particular constructor delegation which avoids code
      duplication or constructor helper functions.  However, this also means a
      change to the minimum gcc version supported which is now 4.7 rather than
      4.5.
      
      Note that gcc-4.7 does not support the entire C++11 standard but does
      support all of the functionality currently needed for further OpenFOAM
      development.  The minimum gcc-version which supports the entire C++11
      standard is 4.8 which is now the recommended minimum gcc version.
      7996a913
    • Mark Olesen's avatar
      DEFEATURE: remove samm, pro-am, prostar3 convertors (issue #204) · b475ae85
      Mark Olesen authored
      - these frontends are defunct and their formats were quite a mess.
        Prostar 4 versions (star4ToFoam, foamToStarMesh) should be used
        instead.
      b475ae85
  20. Jul 31, 2016
  21. Jul 13, 2016
    • Mark Olesen's avatar
      STYLE: clean out clutter in paraview config files (issue #176) · 9e2259c1
      Mark Olesen authored
      Now reduced to 3 environment variables:
          ParaView_DIR         - paraview installation directory
          ParaView_INCLUDE_DIR - paraview include directory
          PV_PLUGIN_PATH       - paraview plugin directory for OpenFOAM modules
      
      Previously also had (ParaView_MAJOR, ParaView_VERSION).
      
      ThirdParty makeParaView adjusted accordingly.
      
      ENH: improved configuration possibility for non-ThirdParty paraview
      installation.
      
      BUG: csh foamPV alias was completely incorrect.
      9e2259c1
  22. Jul 12, 2016
    • Mark Olesen's avatar
      STYLE: cleanup compiler settings (issue #176) · 787b19c4
      Mark Olesen authored
      - export/setenv WM_COMPILER_TYPE as suggested by Mattijs.
      
      - for overall consistency, don't carp about an unset WM_COMPILER_TYPE,
        since this would only be on the first instance (prior to the
        export/setenv) and would be confusing about why/when this message
        may occur.
      
      - reduce clutter: only use (system|ThirdParty) for WM_COMPILER_TYPE.
        Drop the old 'OpenFOAM' setting for WM_COMPILER_TYPE, which was
        transitional in early 2011.
      
      - make the error messages more meaningful
      787b19c4
  23. Sep 29, 2016
  24. Jul 06, 2016
  25. Jul 05, 2016
  26. Jul 01, 2016
  27. Jun 30, 2016
  28. Jun 29, 2016
  29. Jun 28, 2016