- add "point data" or "face data" note to the boundaryData output
  for easier diagnositics in the future.

BACKPORT: AllwmakeParseArguments prefix handling from v2012

- the generic constructor could be called twice in pointPatchField::New,
  which results in an attempt to transfer tokens twice.

- number of fields was not set.
- interpolated surfaces incorrectly written for all formats

BUG: globalSum needed in the merit functions' directional derivative (fixes #1949)

Closes #1949

See merge request !403

Vaggelis Papoutsis authored 4 years ago and Andrew Heather committed 4 years ago

Does not affect the current functionality of shape optimisation.

BUG: Wrong First extrapolated value of the merit function (fixes #1948)

Closes #1948

See merge request !402

Vaggelis Papoutsis authored 4 years ago and Andrew Heather committed 4 years ago

Affected only the first optimisation cycle, if line search was enabled

If eta was not set explicitly, it was computed after evaluating the
directional derivative of the merit function, which was computed
wrongly, leading to an erroneous value of the extrapolated merit
function value.

BUG: collated format and writing of NURBS3DVolume CPs - see #1947

See merge request Development/openfoam!401

The if(Pstream::master()) clause in NURBS3DVolume::writeCpsInDict() was
causing the fileName of the regIOobject not to be allocated in all
processors, giving problems when masterUncollatedFileOperation::masterOp
was called by collatedFileOperation::writeObject for the mkDirOp.

- fixed indexing error (crashes under windows).
  No crash but still incorrect on other systems

- no limit to the number of ways of filing ptscotch libraries.
  RedHat/Fedora/CentOS should look for these directories:

      ptscotch include=/usr/include/openmpi-x86_64
      ptscotch library=/usr/lib64/openmpi/lib

  when MPI_ARCH_PATH=/usr/lib64/openmpi
  and mpicc --showme:compile yields -I/usr/include/openmpi-x86_64

ENH: limit output to 25 cell types per line for readability

- makes it easier to trace potential format errors etc

STYLE: downgrade warning about polyhedrals to a simple info message

- can assume that polyhedral support is widespread enough to not
  warrant a warning.

- had calculated boundaries (default) for the evaluated variables,
  which meant they retained their initialized values (usually Zero).

  This normally goes unnoticed, since the boundary values are largely
  irrelevant in the volField expressions. However, when applying
  functions that balk at a zero value - eg, log() - this raises a
  floating point exception.

  These boundary should be zeroGradient, since the evaluated variables
  correspond to the internalField only. Could continue to use
  calculated, but then need to set the calculated boundary values from
  the patch internal field manually.

- two occurrences where FatalIOErrorInLookup used exit(FatalError)
  instead of exit(FatalIOError), which caused the error messages
  to be lost.

Problem was initial value of zone (transported label) was
still 0. Fixed by properly checking for 'valid' state.

- on ArchLinux, everything is installed under /usr/include/scotch.

  The detection script uses SCOTCH_ARCH_PATH as an initial guess for
  ptscotch as well. However, on the second pass, it has an absolute
  value ("/usr") instead of a logical one ("scotch-system").
  This resulted in the logic for handling scotch+ptscotch subdirs
  being bypassed.

- the problem arises when output fields are missing on some
  processors.

  When the information is combined, the resulting HashTables can have
  different insertion orders. This poses an issue when there are hash
  key collisions and thus different chaining.

- Use sorted order.

Triggered when running e.g. postProcess

- specifying gradientExpr without a valueExpr, a missing fractionExpr
  should be treated as 0 (gradient only), not as 1 (value only)

ENH: improve sanity checks + evaluation short-cuts in exprMixedFvPatchField

- incorrect branching logic caused the "0" case to be ignored

- single entry point to handle negative expansions etc.
  Reduces typos and forgotten code (as per #1841)

- mostly only tripped when using fractional edge grading, since this
  is where the list reading is used. Overseen in commit 7da0b5be.