sergio authored 2 years ago and Kutalmış Berçin committed 2 years ago

thermoTools is a relocation of various existing tools:

- src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/
- src/semiPermeableBaffle/derivedFvPatchFields/
- src/thermophysicalModels/thermophysicalPropertiesFvPatchFields/liquidProperties/

ENH: Allwmake: reordering various compilation steps

Co-authored-by: Kutalmis Bercin <kutalmis.bercin@esi-group.com>

This is on
- incompressible/pimpleFoam/laminar/mixerVesselAMI2D/mixerVesselAMI2D-topologyChange
- redistributePar -reconstruct
where the fvMesh::updateMesh does an early trigger of
mesh.phi() calculation

Specific to the VOF-to-lagrangian FO is to generate particles
which potentially do not relate to the mesh. So here they
are preserved instead of trying to locate them on the
reconstructed mesh. Note: this has the same effect
of actually copying the file...

s2s linear system solution using lduMatrix

See merge request !550

sergio authored 3 years ago and Andrew Heather committed 2 years ago

ENH: Adding report after matrix smoothing

TUT: remove paraFoam hints from tutorials (mostly only need paraview now)

STYLE: remove reference to paraview _SM plugins (OpenFOAM-v1912 and earlier)

BUG: inconsistent "U" name on re-read (buoyancyEnergy)

STYLE: fix spelling inconsistencies

- for tracing tutorials execution

ENH: setTurbulenceFields: new automatic initialisation method for turbulence fields

See merge request !545

Kutalmış Berçin authored 2 years ago and Mark OLESEN committed 2 years ago

TUT: cylinder: fix the order in Allclean

species and heat adsorption BC's and fvOption source

See merge request !548

sergio authored 3 years ago and Kutalmış Berçin committed 2 years ago

speciesSorption is a zeroGradient BC which absorbs mass given by a first
order time derivative, absoprtion rate and an equilibrium value
calculated based on internal species values next to the wall.

patchCellsSource is a source fvOption which applies to the corresponding
species and apply the source calculated on the speciesSorption BC.

A new abstract virtual class was created to group BC's which
don't introduce a source to the matrix (i.e zeroGradient) but calculate
a mass sink/source which should be introduced into the matrix. This
is  done through the fvOption patchCellsSource.

support surface writer output transform (#2505)

See merge request !549

Mark OLESEN authored 2 years ago and Andrew Heather committed 2 years ago

- this allows the "relocation" of sampled surfaces. For example,
  to reposition into a different coordinate system for importing
  into CAD.

- incorporate output scaling for all surface writer types.

  This was previously done on an adhoc basis for different writers,
  but with now included in the base-level so that all writers
  can automatically use scale + transform.

  Example:

  formatOptions
  {
      vtk
      {
          scale 1000;  // m -> mm
          transform
          {
              origin  (0.05 0 0);
              rotation axisAngle;
              axis    (0 0 1);
              angle   -45;
          }
      }
  }

ENH: adjoint code review

See merge request !518

Vaggelis Papoutsis authored 2 years ago and Andrew Heather committed 2 years ago

Necessary when grad(Ua) is cached

Vaggelis Papoutsis authored 2 years ago and Andrew Heather committed 2 years ago

Partially fixes #2502 (see discussion there)

Vaggelis Papoutsis authored 2 years ago and Andrew Heather committed 2 years ago

in RASModelVariables were doing this by checking whether the
corresponding pointer was allocated. In some cases, however, even if the
field does not exist, the pointer is not null, leading to the wrong
output. Made the correspding functions virtual and overwritten their
return values in the derived classes. Kept the initial implementation in
base to facilitate the clone function.

Vaggelis Papoutsis authored 2 years ago and Andrew Heather committed 2 years ago

in cases with more than one primal or adjoint solvers

TUT: removed all occurances of useSolverNameForFields
from the optimisation tutorials since it is now set
automatically.

Vaggelis Papoutsis authored 3 years ago and Andrew Heather committed 2 years ago

to be in line with the changes in 00f46a2c52 and added the same tutorial
which performs the optimisation in one-go, for comparison.

Vaggelis Papoutsis authored 3 years ago and Andrew Heather committed 2 years ago

volBSplinesBase const, since the no private/protected
variable is changed there.

Vaggelis Papoutsis authored 3 years ago and Andrew Heather committed 2 years ago

in the sensitivity patches, symmetry::evaluate() needs access to the
internalField which does exist, leading to wrong memory access.

Fixed by specifying a calculated type fvPatchField for all patches when
creating a boundaryField<Type>

Using a symmetry(Plane) as a sensitivity patch is quite rare and
borderline wrong, but this provides a fix nonetheless.

Vaggelis Papoutsis authored 3 years ago and Andrew Heather committed 2 years ago

The multiplier of grad(dxdb) is a volTensorField which, by itself, is
memory consuming. The function computing it though was sloppy in terms
of memory management, constituting the peak memory consumption during an
adjoint optimisation. Initial changes to remedy the problem include the
deallocation of some of the volTensorFields included in the computation
of grad(dxdb) once unneeded, the utilisation of volSymmTensorFields
instead of volTensorFields where possible and avoiding allocating some
unnecessary intermediate fields.

Actions to further reduce memory consumption:

- For historical reasons, the code computes/stores the transpose of
  grad(dxdb), which is then transposed when used in the computation of
  the FI or the ESI sensitivity derivatives.  This redundant
  transposition can be avoid, saving the allocation of an additional
  volTensorField, but the changes need to permeate a number of places in
  the code that contribute to grad(dxdb) (e.g.  ATC, adjoint turbulence
  models, adjoint MRF, etc).
- Allocation of unnecessary pointers in the objective class should be
  avoided.