Skip to content
Snippets Groups Projects
  1. Oct 28, 2016
    • Mark Olesen's avatar
      BUG: etc/bashrc incorrect behaviour if sourced locally (issue #280) · b8448671
      Mark Olesen authored
      - It is incorrect to prefix the assignment with an 'export' since this
        automatically marks the overall command as successful and circumvents
        the fallback.
      
        There is no simple way to have proper behaviour when sourced with a
        local directory path, but at least it now uses the fallback.
      
        It is still easy to wreak the mechanism with valid but confusing input.
        For example,
      
           ". /path/to/openfoam/etc/././bashrc"
      
        The only real certainty is that "${BASH_SOURCE%/*}"
        should point to the 'etc/' directory. In which case,
      
            cd ${BASH_SOURCE%/*}    # <- now in the etc/ directory
            pwd=$(pwd -P)           # <- fully-qualified path to etc/
            pwd=${pwd%/*/*}         # <- up two parent levels
      
        - This works with ". ./bashrc", but fails with ". bashrc"
          (probably not so common).
        - Con: The construct requires an additional sub-shell.
      b8448671
    • Andrew Heather's avatar
    • Mark Olesen's avatar
      053b22a9
  2. Sep 29, 2016
  3. Sep 28, 2016
  4. Sep 03, 2016
  5. Aug 23, 2016
    • Henry Weller's avatar
      etc/bashrc, etc/config.sh: · c482490a
      Henry Weller authored
        - "$FOAM_USER_APPBIN" and "$FOAM_USER_LIBBIN" have been added to
          "foamOldDirs" in "etc/bashrc" and "etc/config.sh/unset"
      
        - "$OPAL_PREFIX" is now undefined in the option "SYSTEMOPENMPI" within
          "etc/config.sh/mpi", but only if the path defined in this variable
          is cleaned when using "foamCleanPath".
      
        - "$OPAL_PREFIX" is now also conditionally undefined in
          "etc/config.sh/unset" when the path is picked up by "foamCleanPath".
      
      Patch contributed by Bruno Santos
      Resolved bug-report http://bugs.openfoam.org/view.php?id=2210
      c482490a
  6. Jul 12, 2016
    • Mark Olesen's avatar
      STYLE: cleanup compiler settings (issue #176) · 787b19c4
      Mark Olesen authored
      - export/setenv WM_COMPILER_TYPE as suggested by Mattijs.
      
      - for overall consistency, don't carp about an unset WM_COMPILER_TYPE,
        since this would only be on the first instance (prior to the
        export/setenv) and would be confusing about why/when this message
        may occur.
      
      - reduce clutter: only use (system|ThirdParty) for WM_COMPILER_TYPE.
        Drop the old 'OpenFOAM' setting for WM_COMPILER_TYPE, which was
        transitional in early 2011.
      
      - make the error messages more meaningful
      787b19c4
  7. Jul 01, 2016
  8. Jun 28, 2016
  9. Jun 14, 2016
  10. Jun 08, 2016
  11. Jun 06, 2016
  12. May 05, 2016
  13. May 02, 2016
  14. Apr 29, 2016
  15. Mar 09, 2016
    • Henry Weller's avatar
      etc/bashrc, etc/config.sh: Updates provided by Bruno Santos: · 4409a0ea
      Henry Weller authored
       1. "foamCompiler" was changed to a more permanent "WM_COMPILER_TYPE"
          environment variable, so that it can be used by 3rd party
          installation scripts, such as "makeGcc", "makeLLVM" and so on. More
          on this will be provided in issue #1215.
      
       2. The script functions such as "_foamSource()" and "_foamAddPath()"
          were moved to a new file "etc/config.sh/functions". It has the
          ability to set or unset, depending on whether "WM_BASH_FUNCTIONS" is
          defined or not. This allows for these functions to be reused by
          other scripts, such as "makeGcc".
      
       3. The script "etc/config.sh/CGAL" relies on whether a local
          environment variable "SOURCE_CGAL_VERSIONS_ONLY" is defined or not,
          so that it will load only the version settings if it's defined. This
          is to make it easier to call this script from "makeCGAL". Although
          it still feels a bit of a clunky hack, but I didn't manage to deduce
          any other way we could do this :( I didn't add indentation within
          the if-block, to make it easier to read the changes. In addition,
          the local variable "common_path" is used to shorten the length of
          the lines and use slightly less repeated code.
      
       4. Added another new script "etc/config.sh/compiler", which has only
          the version numbers for the compilers taken out from the "settings"
          file. It currently depends on "WM_COMPILER_TYPE" for setting the
          variables, the same way it did with "foamCompiler". This script is
          now always sourced from the "settings" file, for the following
          reasons:
      
         - "makeGCC" and "makeLLVM" can now take advantage of this script file.
      
         - The example "compiler" script (detailed next) can rely on this
           script file and then override parameters on-demand, as well as
           allowing for system compilers to have dedicated settings, such as
           setting "WM_CC". This is similar to how the example environment
           script for "paraview" works.
      
       5. To the script "etc/config.sh/example/compiler" were added a few more examples:
      
         - It now starts with a block where it first loads the default "compiler" script.
      
         - Has a "WM_COMPILER=Gcc48u" case example for when we try to use GCC
           4.8 in Ubuntu 15.10. This is just to give the idea that in a
           particular system, we might have several system-wide compiler
           versions. For example, in Ubuntu 15.10, there is GCC 4.7, 4.8 and
           5.2, which could be used for testing performances or compatibility
           with some other 3rd party library.
      
         - Has the "WM_COMPILER=Icc" case example, related to the original bug
           report, where "WM_CC=icc" and "WM_CXX=icpc", so that the user then
           simply copies this file to their own local preferences folder.
      
       6. Small bug fix in "etc/config.sh/mpi", where unsetting "minBufferSize" was missing at the end of the script.
      
       7. Small change in "etc/config.sh/paraview", where "CMAKE_ROOT" is set
          along with "CMAKE_HOME". This is due to a rare issue that occurs on
          people's systems where they have a custom system-wide CMake version
          installed and which is used by having "CMAKE_ROOT" set on that
          environment. This can mess up OpenFOAM's custom ParaView builds,
          given that conflicting CMake versions can lead to not building
          ParaView at all.
      
         - For more details about "CMAKE_ROOT":
           https://cmake.org/Wiki/CMake_Useful_Variables [^]
      
       8. The scripts "_foamAddPath _foamAddLib _foamAddMan" were not being
          unset at the end of "settings". They are now unset at the end of
          "bashrc", through a call to the new double-use "functions" script.
      
      Additionally all references to "foamCompiler" have been changed to
      "WM_COMPILER_TYPE".
      
      See also http://www.openfoam.org/mantisbt/view.php?id=1232
      4409a0ea
  16. Feb 22, 2016
  17. Feb 15, 2016
  18. Feb 10, 2016
  19. Dec 22, 2015
  20. Aug 07, 2015
  21. May 17, 2015
  22. May 14, 2015
  23. Mar 08, 2015
  24. Dec 31, 2014
    • Henry's avatar
      Added and verified support for 64bit labels · 325b003b
      Henry authored
      To compile with 64bit labels set
      
      WM_LABEL_SIZE=64
      
      in ~/OpenFOAM/dev/prefs.sh
      
      source ~/.bashrc
      
      then Allwmake in OpenFOAM-dev.
      
      This will build into for example OpenFOAM-dev/platforms/linux64ClangDPInt64Opt
      
      If WM_LABEL_SIZE is unset or set to 32:
      
      WM_LABEL_SIZE=32
      
      the build would be placed into OpenFOAM-dev/platforms/linux64ClangDPInt32Opt
      
      Thus both 32bit and 64bit label builds can coexist without problem.
      325b003b
  25. Dec 16, 2014
  26. Dec 11, 2014
  27. Dec 10, 2014
  28. Feb 17, 2014
  29. Jan 28, 2014
  30. Jan 10, 2014